Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle message and exitflag in histories #1203

Merged
merged 3 commits into from
Nov 21, 2023

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Nov 20, 2023

  • Add properties message and exitflag to HistoryBase
  • Implement them in derived classes where missing
  • Store them in CountHistoryBase

Resolves #1191

* Add properties `message` and `exitflag` to `HistoryBase`
* Implement them in derived classes where missing
* Store them in `CountHistoryBase`

Resolves ICB-DCM#1191
@codecov-commenter
Copy link

codecov-commenter commented Nov 20, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (6935cee) 84.02% compared to head (81f0d1e) 82.70%.

Files Patch % Lines
pypesto/history/base.py 91.30% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1203      +/-   ##
===========================================
- Coverage    84.02%   82.70%   -1.33%     
===========================================
  Files          148      148              
  Lines        11752    11775      +23     
===========================================
- Hits          9875     9738     -137     
- Misses        1877     2037     +160     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dweindl dweindl linked an issue Nov 20, 2023 that may be closed by this pull request
@m-philipps
Copy link
Contributor

Should exit flag and message also be listed as possible entries here?

# all possible history entries
ALL_KEYS = (X, *RESULT_KEYS, TIME)

@dweindl
Copy link
Member Author

dweindl commented Nov 20, 2023

Should exit flag and message also be listed as possible entries here?

No, those are only the fields we want to save on every iteration / function evaluation.

@dweindl dweindl self-assigned this Nov 21, 2023
@dweindl dweindl merged commit a280f4b into ICB-DCM:develop Nov 21, 2023
18 checks passed
@dweindl dweindl deleted the fix_1191_memhist_final branch November 21, 2023 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MemoryHistory does not store exitflag and message
4 participants