Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Hdf5History.from_history() #1211

Merged
merged 6 commits into from
Nov 29, 2023
Merged

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Nov 22, 2023

Adds Hdf5History.from_history() which allows saving other histories as HDF5 later on.

(+ adds support for pathlib.Path)

Closes #1196

@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2023

Codecov Report

Attention: 398 lines in your changes are missing coverage. Please review.

Comparison is base (160c2a8) 88.16% compared to head (7d9744d) 82.76%.
Report is 448 commits behind head on develop.

Files Patch % Lines
pypesto/ensemble/ensemble.py 69.36% 68 Missing ⚠️
...ypesto/hierarchical/spline_approximation/solver.py 83.68% 47 Missing ⚠️
pypesto/ensemble/util.py 65.13% 38 Missing ⚠️
pypesto/hierarchical/optimal_scaling/solver.py 93.53% 26 Missing ⚠️
pypesto/history/base.py 88.57% 24 Missing ⚠️
pypesto/hierarchical/petab.py 84.56% 23 Missing ⚠️
pypesto/engine/mpi_pool.py 0.00% 22 Missing ⚠️
pypesto/hierarchical/inner_calculator_collector.py 89.04% 16 Missing ⚠️
...pesto/hierarchical/spline_approximation/problem.py 89.18% 16 Missing ⚠️
pypesto/hierarchical/optimal_scaling/calculator.py 75.86% 14 Missing ⚠️
... and 19 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1211      +/-   ##
===========================================
- Coverage    88.16%   82.76%   -5.41%     
===========================================
  Files           79      148      +69     
  Lines         5257    11863    +6606     
===========================================
+ Hits          4635     9818    +5183     
- Misses         622     2045    +1423     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dweindl dweindl linked an issue Nov 22, 2023 that may be closed by this pull request
Adds `Hdf5History.from_history()` which allows saving other histories as HDF5 later on.

Closes ICB-DCM#1196
@dweindl dweindl marked this pull request as ready for review November 22, 2023 15:45
@dweindl dweindl self-assigned this Nov 28, 2023
Copy link
Collaborator

@PaulJonasJost PaulJonasJost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for the test as well.

test/base/test_history.py Outdated Show resolved Hide resolved
dweindl and others added 2 commits November 29, 2023 15:42
Co-authored-by: Paul Jonas Jost <70631928+PaulJonasJost@users.noreply.github.com>
@dweindl dweindl merged commit cec8f21 into ICB-DCM:develop Nov 29, 2023
18 checks passed
@dweindl dweindl deleted the feature_1196_hist2hdf5 branch November 29, 2023 15:04
This was referenced Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Hdf5History.from_history()
3 participants