-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Hdf5History.from_history()
#1211
Conversation
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #1211 +/- ##
===========================================
- Coverage 88.16% 82.76% -5.41%
===========================================
Files 79 148 +69
Lines 5257 11863 +6606
===========================================
+ Hits 4635 9818 +5183
- Misses 622 2045 +1423 ☔ View full report in Codecov by Sentry. |
78cfbf0
to
137c6b4
Compare
Adds `Hdf5History.from_history()` which allows saving other histories as HDF5 later on. Closes ICB-DCM#1196
137c6b4
to
f25cd74
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks for the test as well.
Co-authored-by: Paul Jonas Jost <70631928+PaulJonasJost@users.noreply.github.com>
Adds
Hdf5History.from_history()
which allows saving other histories as HDF5 later on.(+ adds support for
pathlib.Path
)Closes #1196