Scatter search documentation / use local optimizer by default #1214
Conversation
* Extended scatter search documentation * Changed `get_default_ess_options` to default to fides for local optimization instead of no local optimizer * Added a wrapper for fides to forward walltime and function evaluation limits
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #1214 +/- ##
===========================================
+ Coverage 82.67% 83.94% +1.26%
===========================================
Files 148 148
Lines 11799 11826 +27
===========================================
+ Hits 9755 9927 +172
+ Misses 2044 1899 -145 ☔ View full report in Codecov by Sentry. |
| return [ | ||
| settings[0], | ||
| *(itertools.islice(itertools.cycle(settings[1:]), num_workers - 1)), | ||
| ] | ||
|
|
||
|
|
||
| class SacessFidesFactory: |
There was a problem hiding this comment.
As far as I can see, the factory is a new addition, providing ess with fitting fides optimisers? Is it a lot more effort to generalise this to more than just fides?
There was a problem hiding this comment.
For optimizers that support walltime+function limits it would be pretty easy.
See also #1181 (comment), which would be my preferred solution for it. If we go for that, then this class would be removed.
Here, the preliminary goal would be just to have some default "that works".
get_default_ess_optionsto default to fides for local optimization instead of no local optimizer