Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 1209 #1216

Merged
merged 4 commits into from
Nov 29, 2023
Merged

Fix 1209 #1216

merged 4 commits into from
Nov 29, 2023

Conversation

PaulJonasJost
Copy link
Collaborator

Closes #1209. Happens due to amici not correctly calculating the initial jacobin and bad error handling of scipy.

…cobian paired with scipy bad error handling. Happens max 1:1e3 times. Therefore currently rerun the test.
Copy link
Member

@dweindl dweindl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. A potentially cleaner solution would be using checked startpoints (problem = importer.create_problem(obj, startpoint_kwargs={'check_fval': True, 'check_grad': True})).

@codecov-commenter
Copy link

codecov-commenter commented Nov 28, 2023

Codecov Report

Attention: 404 lines in your changes are missing coverage. Please review.

Comparison is base (160c2a8) 88.16% compared to head (aacccd0) 83.95%.
Report is 447 commits behind head on develop.

Files Patch % Lines
pypesto/ensemble/ensemble.py 69.36% 68 Missing ⚠️
...ypesto/hierarchical/spline_approximation/solver.py 83.68% 47 Missing ⚠️
pypesto/ensemble/util.py 65.13% 38 Missing ⚠️
pypesto/history/base.py 84.76% 32 Missing ⚠️
pypesto/hierarchical/optimal_scaling/solver.py 93.53% 26 Missing ⚠️
pypesto/hierarchical/petab.py 84.56% 23 Missing ⚠️
pypesto/engine/mpi_pool.py 0.00% 22 Missing ⚠️
pypesto/hierarchical/inner_calculator_collector.py 89.04% 16 Missing ⚠️
...pesto/hierarchical/spline_approximation/problem.py 89.18% 16 Missing ⚠️
pypesto/hierarchical/optimal_scaling/calculator.py 75.86% 14 Missing ⚠️
... and 19 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1216      +/-   ##
===========================================
- Coverage    88.16%   83.95%   -4.22%     
===========================================
  Files           79      148      +69     
  Lines         5257    11830    +6573     
===========================================
+ Hits          4635     9932    +5297     
- Misses         622     1898    +1276     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PaulJonasJost PaulJonasJost merged commit eac04da into develop Nov 29, 2023
18 checks passed
@PaulJonasJost PaulJonasJost deleted the fix_1164 branch November 29, 2023 12:24
This was referenced Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ValueError in test/petab/test_amici_objective.py::test_error_leastsquares_with_ssigma
3 participants