-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 1209 #1216
Fix 1209 #1216
Conversation
…cobian paired with scipy bad error handling. Happens max 1:1e3 times. Therefore currently rerun the test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. A potentially cleaner solution would be using checked startpoints (problem = importer.create_problem(obj, startpoint_kwargs={'check_fval': True, 'check_grad': True})
).
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #1216 +/- ##
===========================================
- Coverage 88.16% 83.95% -4.22%
===========================================
Files 79 148 +69
Lines 5257 11830 +6573
===========================================
+ Hits 4635 9932 +5297
- Misses 622 1898 +1276 ☔ View full report in Codecov by Sentry. |
Closes #1209. Happens due to amici not correctly calculating the initial jacobin and bad error handling of scipy.