Fix incorrect indexing in `pypesto.profile.profile_next_guess.get_reg… #1226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_polynomial` There seems to be an indexing error in `pypesto.profile.profile_next_guess.get_reg_polynomial`, resulting in too few points being used for extrapolating parameter trajectories. In the second case, not only too few, but also not the most recent parameter values are used. Closes ICB-DCM#1224
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #1226 +/- ##
===========================================
- Coverage 88.16% 84.09% -4.08%
===========================================
Files 79 148 +69
Lines 5257 11857 +6600
===========================================
+ Hits 4635 9971 +5336
- Misses 622 1886 +1264 ☔ View full report in Codecov by Sentry. |
PaulJonasJost
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…_polynomial`
There seems to be an indexing error in
pypesto.profile.profile_next_guess.get_reg_polynomial, resulting in too few points being used for extrapolating parameter trajectories. In the second case, not only too few, but also not the most recent parameter values are used.Closes #1224