Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip the trace, if trace is empty. Occurs for infinite initial values. #1234

Merged
merged 3 commits into from
Dec 5, 2023

Conversation

PaulJonasJost
Copy link
Collaborator

Closes #1164

@codecov-commenter
Copy link

codecov-commenter commented Dec 4, 2023

Codecov Report

Attention: 411 lines in your changes are missing coverage. Please review.

Comparison is base (160c2a8) 88.16% compared to head (4d88298) 81.54%.
Report is 459 commits behind head on develop.

Files Patch % Lines
pypesto/ensemble/ensemble.py 68.46% 70 Missing ⚠️
pypesto/ensemble/util.py 55.04% 49 Missing ⚠️
...ypesto/hierarchical/spline_approximation/solver.py 83.68% 47 Missing ⚠️
pypesto/hierarchical/optimal_scaling/solver.py 93.53% 26 Missing ⚠️
pypesto/history/base.py 88.57% 24 Missing ⚠️
pypesto/hierarchical/petab.py 84.56% 23 Missing ⚠️
pypesto/engine/mpi_pool.py 0.00% 22 Missing ⚠️
pypesto/hierarchical/inner_calculator_collector.py 89.04% 16 Missing ⚠️
...pesto/hierarchical/spline_approximation/problem.py 89.18% 16 Missing ⚠️
pypesto/hierarchical/optimal_scaling/calculator.py 75.86% 14 Missing ⚠️
... and 19 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1234      +/-   ##
===========================================
- Coverage    88.16%   81.54%   -6.63%     
===========================================
  Files           79      148      +69     
  Lines         5257    11865    +6608     
===========================================
+ Hits          4635     9675    +5040     
- Misses         622     2190    +1568     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@dweindl dweindl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@PaulJonasJost PaulJonasJost merged commit b3fb62c into develop Dec 5, 2023
18 checks passed
@PaulJonasJost PaulJonasJost deleted the fix_history_of_failed_starts branch December 5, 2023 07:48
This was referenced Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

doc/example/store.ipynb: ValueError: zero-size array to reduction operation minimum which has no identity
4 participants