Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEtab.jl makes problems since 2.5.1 #1256

Merged
merged 2 commits into from
Dec 18, 2023
Merged

PEtab.jl makes problems since 2.5.1 #1256

merged 2 commits into from
Dec 18, 2023

Conversation

PaulJonasJost
Copy link
Collaborator

@PaulJonasJost PaulJonasJost commented Dec 17, 2023

Only until problem is solved with Sebastian.

@codecov-commenter
Copy link

codecov-commenter commented Dec 17, 2023

Codecov Report

Attention: 384 lines in your changes are missing coverage. Please review.

Comparison is base (160c2a8) 88.16% compared to head (7593a1a) 83.78%.
Report is 479 commits behind head on develop.

Files Patch % Lines
pypesto/ensemble/ensemble.py 69.77% 68 Missing ⚠️
...ypesto/hierarchical/spline_approximation/solver.py 82.62% 53 Missing ⚠️
pypesto/ensemble/util.py 65.13% 38 Missing ⚠️
pypesto/hierarchical/optimal_scaling/solver.py 93.53% 26 Missing ⚠️
pypesto/history/base.py 88.57% 24 Missing ⚠️
pypesto/hierarchical/petab.py 84.76% 23 Missing ⚠️
pypesto/engine/mpi_pool.py 0.00% 22 Missing ⚠️
pypesto/hierarchical/inner_calculator_collector.py 88.51% 17 Missing ⚠️
...pesto/hierarchical/spline_approximation/problem.py 89.18% 16 Missing ⚠️
pypesto/hierarchical/problem.py 89.05% 15 Missing ⚠️
... and 15 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1256      +/-   ##
===========================================
- Coverage    88.16%   83.78%   -4.39%     
===========================================
  Files           79      148      +69     
  Lines         5257    12066    +6809     
===========================================
+ Hits          4635    10109    +5474     
- Misses         622     1957    +1335     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PaulJonasJost PaulJonasJost marked this pull request as ready for review December 18, 2023 05:29
@PaulJonasJost PaulJonasJost requested a review from a team as a code owner December 18, 2023 05:29
@PaulJonasJost PaulJonasJost merged commit 0e75d31 into develop Dec 18, 2023
18 checks passed
This was referenced Jan 30, 2024
@PaulJonasJost PaulJonasJost deleted the hot_fix_petabjl branch September 24, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants