Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select: custom minimize method #1264

Merged
merged 7 commits into from
Jan 4, 2024
Merged

Select: custom minimize method #1264

merged 7 commits into from
Jan 4, 2024

Conversation

dilpath
Copy link
Member

@dilpath dilpath commented Jan 3, 2024

No description provided.

@dilpath dilpath requested a review from dweindl January 3, 2024 10:14
@codecov-commenter
Copy link

codecov-commenter commented Jan 3, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (bcfd618) 75.75% compared to head (492cfe5) 81.35%.

Files Patch % Lines
pypesto/select/problem.py 77.77% 2 Missing ⚠️
pypesto/select/model_problem.py 83.33% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1264      +/-   ##
===========================================
+ Coverage    75.75%   81.35%   +5.59%     
===========================================
  Files          148      148              
  Lines        12075    12088      +13     
===========================================
+ Hits          9148     9834     +686     
+ Misses        2927     2254     -673     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dweindl
Copy link
Member

dweindl commented Jan 4, 2024

I tested it with doc/example/model_selection.ipynb and SacessOptimizer and it worked well after #1265.

from pypesto.optimize.ess import SacessOptimizer
sacess = SacessOptimizer(num_workers=4, max_walltime_s=10)

best_models = pypesto_select_problem_4.select_to_completion(
    method=Method.FORWARD,
    criterion=Criterion.AICC,
    select_first_improvement=True,
    startpoint_latest_mle=True,
    criterion_threshold=10,
    model_problem_options={
        'minimize_method': sacess.minimize,
    }
)

Thanks!

Co-authored-by: Daniel Weindl <dweindl@users.noreply.github.com>
@dilpath
Copy link
Member Author

dilpath commented Jan 4, 2024

I tested it with doc/example/model_selection.ipynb and SacessOptimizer and it worked well after #1265.

Great! Thanks for the example and improvements.

@dilpath dilpath merged commit 0826c13 into develop Jan 4, 2024
18 checks passed
@dilpath dilpath deleted the select_minimize_method branch January 4, 2024 13:53
This was referenced Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants