Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESSOptimizer: Include results for local searches in OptimizeResult #1270

Merged
merged 4 commits into from
Jan 16, 2024

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Jan 5, 2024

Include results for all local searches in scatter search OptimizeResult. Those might be useful for creating ensembles or waterfall plots.

@dweindl dweindl self-assigned this Jan 5, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 5, 2024

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (1c5580d) 59.19% compared to head (3398ddf) 74.92%.

Files Patch % Lines
pypesto/optimize/ess/ess.py 14.28% 12 Missing ⚠️
pypesto/optimize/ess/sacess.py 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #1270       +/-   ##
============================================
+ Coverage    59.19%   74.92%   +15.73%     
============================================
  Files          151      151               
  Lines        12331    12333        +2     
============================================
+ Hits          7299     9241     +1942     
+ Misses        5032     3092     -1940     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dweindl dweindl marked this pull request as ready for review January 15, 2024 10:31
Copy link
Collaborator

@PaulJonasJost PaulJonasJost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, thanks :)

@dweindl dweindl merged commit cbde009 into ICB-DCM:develop Jan 16, 2024
18 checks passed
@dweindl dweindl deleted the sacess_result_local branch January 16, 2024 13:27
This was referenced Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants