Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: Clear amici and conversion reaction notebook output #1275

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Jan 9, 2024

A subset of #1246.

After #1272.

@dweindl dweindl self-assigned this Jan 9, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e389257) 53.32% compared to head (865e7bb) 53.32%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1275   +/-   ##
========================================
  Coverage    53.32%   53.32%           
========================================
  Files          148      148           
  Lines        12122    12122           
========================================
  Hits          6464     6464           
  Misses        5658     5658           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

A subset of ICB-DCM#1246.

After ICB-DCM#1272.

Co-authored-by: Doresic <domagoj.doresic@gmail.com>
@dweindl dweindl marked this pull request as ready for review January 9, 2024 08:54
@dweindl dweindl requested a review from a team as a code owner January 9, 2024 08:54
Copy link
Collaborator

@PaulJonasJost PaulJonasJost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could not inspect it well, as it is a fork, but first few code spaces seem fine.

@dweindl dweindl merged commit 8c9a049 into ICB-DCM:develop Jan 9, 2024
18 checks passed
@dweindl dweindl deleted the doc_nb_conv branch January 9, 2024 10:56
This was referenced Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants