Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include pymc in the documentation. #1305

Merged
merged 7 commits into from
Feb 21, 2024
Merged

Conversation

PaulJonasJost
Copy link
Collaborator

Pymc was not listed in the documentation.

@codecov-commenter
Copy link

codecov-commenter commented Feb 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (34e89b3) 84.52% compared to head (c975c9a) 84.41%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1305      +/-   ##
===========================================
- Coverage    84.52%   84.41%   -0.12%     
===========================================
  Files          153      153              
  Lines        12456    12457       +1     
===========================================
- Hits         10528    10515      -13     
- Misses        1928     1942      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pypesto/sample/pymc.py Outdated Show resolved Hide resolved
Co-authored-by: Daniel Weindl <dweindl@users.noreply.github.com>
@PaulJonasJost PaulJonasJost marked this pull request as ready for review February 19, 2024 10:23
@@ -48,6 +20,34 @@ def __init__(
effective_sample_size: float = None,
message: str = None,
):
"""
Initialize the McmcPtResult.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are these now documented as constructor parameters? Attributes seems more appropriate

@PaulJonasJost PaulJonasJost merged commit 0c9ef74 into develop Feb 21, 2024
18 checks passed
@PaulJonasJost PaulJonasJost mentioned this pull request Mar 27, 2024
@PaulJonasJost PaulJonasJost deleted the pymc_documentation branch May 3, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants