-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Variational inference with PyMC #1306
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #1306 +/- ##
===========================================
- Coverage 84.48% 83.90% -0.59%
===========================================
Files 157 160 +3
Lines 12959 13051 +92
===========================================
+ Hits 10949 10950 +1
- Misses 2010 2101 +91 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for putting this first draft together :)
Should discuss about further things needed aside from testing, before it can be merged.
…ational_inference
…ational_inference
Mainly tests are missing, but otherwise ready |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All in all, very nice implementation! Thanks.
I left some questions/recommendations that would come up to my mind if I would try to use the module myself.
…ational_inference
I added a wrapper for variational inference with
PyMC
. The wrapper uses thePymcSampler
as basis and directly supports all functions and methods fromPyMC
see here for details on VI.To include this properly in
pyPESTO
one would need to add proper testing and write aResult Object
to save the estimated parameters of the variational distribution.