Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruff codechecks #1307

Merged
merged 29 commits into from
Mar 5, 2024
Merged

Ruff codechecks #1307

merged 29 commits into from
Mar 5, 2024

Conversation

PaulJonasJost
Copy link
Collaborator

Most important to check would be

  • pre-commit-config.yaml
  • pyproject.toml

can flake8 be deleted from tox and .flake8 as well?

Copy link
Member

@dweindl dweindl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Mostly looks good.

.pre-commit-config.yaml Show resolved Hide resolved
pypesto/engine/base.py Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
@dilpath dilpath changed the title Purr codechecks Ruff codechecks Feb 22, 2024
@stephanmg
Copy link
Contributor

Most important to check would be

  • pre-commit-config.yaml
  • pyproject.toml

can flake8 be deleted from tox and .flake8 as well?

Looks good to me. Would remove .flake8.

@codecov-commenter
Copy link

codecov-commenter commented Feb 27, 2024

Codecov Report

Attention: Patch coverage is 45.59322% with 321 lines in your changes are missing coverage. Please review.

Project coverage is 53.32%. Comparing base (f9231f2) to head (ce3c6e6).

❗ Current head ce3c6e6 differs from pull request most recent head 4556bd0. Consider uploading reports for the commit 4556bd0 to get more accurate results

Files Patch % Lines
pypesto/visualize/sampling.py 0.00% 32 Missing ⚠️
pypesto/result/predict.py 0.00% 18 Missing ⚠️
pypesto/visualize/ensemble.py 0.00% 18 Missing ⚠️
pypesto/objective/amici/amici.py 50.00% 16 Missing ⚠️
pypesto/store/read_from_hdf5.py 40.90% 13 Missing ⚠️
pypesto/ensemble/ensemble.py 0.00% 11 Missing ⚠️
pypesto/ensemble/util.py 0.00% 10 Missing ⚠️
pypesto/objective/priors.py 0.00% 9 Missing ⚠️
pypesto/problem/base.py 50.00% 9 Missing ⚠️
pypesto/visualize/dimension_reduction.py 0.00% 9 Missing ⚠️
... and 52 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #1307       +/-   ##
============================================
- Coverage    84.27%   53.32%   -30.96%     
============================================
  Files          153      153               
  Lines        12459    12456        -3     
============================================
- Hits         10500     6642     -3858     
- Misses        1959     5814     +3855     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PaulJonasJost PaulJonasJost merged commit 82b7d5d into develop Mar 5, 2024
18 checks passed
@PaulJonasJost PaulJonasJost deleted the purr_codechecks branch March 5, 2024 14:02
@FFroehlich
Copy link
Contributor

bit late now, but might make sense to add the PR of this commit to a .git-blame-ignore-revs file (see https://docs.github.com/en/repositories/working-with-files/using-files/viewing-a-file#ignore-commits-in-the-blame-view)

@PaulJonasJost
Copy link
Collaborator Author

bit late now, but might make sense to add the PR of this commit to a .git-blame-ignore-revs file (see https://docs.github.com/en/repositories/working-with-files/using-files/viewing-a-file#ignore-commits-in-the-blame-view)

might make sense to include yanks black changes back then as well 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants