Semiquant: Fix spline inner parameter initial values #1313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephanmg
approved these changes
Feb 29, 2024
Doresic
added a commit
that referenced
this pull request
Mar 8, 2024
Repeating the change made in #1313. Somehow it got overwritten to the old version.
Doresic
added a commit
that referenced
this pull request
Mar 14, 2024
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial values of spline inner parameters of each optimization are set to end values of the previous inner optimization, if possible. However, the saving of previous inner parameters was saving the spline knot values, instead of the spline knot differences, which are the inner parameters.
This wasn't a big issue, as the initial values of the inner optimization are not that important (the problem is convex). But in some cases, they were so different that the inner solver stopped early.
Updated the visualization to work with the change.