Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relative: Fix return of relative calculator if sim fails #1315

Merged
merged 4 commits into from
Mar 5, 2024

Conversation

Doresic
Copy link
Contributor

@Doresic Doresic commented Mar 5, 2024

In case of simulation fail, the inner relative calculator did not return inner parameters to be added to the inner result. This caused some ValueError: too many values to unpack (expected 2) as a tuple was expected.

@Doresic Doresic closed this Mar 5, 2024
@Doresic Doresic reopened this Mar 5, 2024
@Doresic Doresic requested a review from dweindl as a code owner March 5, 2024 14:12
@Doresic Doresic changed the base branch from main to develop March 5, 2024 14:12
Copy link
Member

@dweindl dweindl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx 👍

pypesto/hierarchical/inner_calculator_collector.py Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Mar 5, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 53.33%. Comparing base (82b7d5d) to head (0e166a8).

Files Patch % Lines
pypesto/hierarchical/relative/calculator.py 33.33% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #1315       +/-   ##
============================================
- Coverage    84.38%   53.33%   -31.06%     
============================================
  Files          153      153               
  Lines        12456    12456               
============================================
- Hits         10511     6643     -3868     
- Misses        1945     5813     +3868     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Doresic Doresic merged commit ee852cb into develop Mar 5, 2024
18 checks passed
@Doresic Doresic deleted the relative_fix_return_for_simfail branch March 5, 2024 15:35
@PaulJonasJost PaulJonasJost mentioned this pull request Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants