Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed some leftover amici depractions. #1344

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

PaulJonasJost
Copy link
Collaborator

Seems to have missed some last time.

@PaulJonasJost PaulJonasJost self-assigned this Mar 27, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 27, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 84.26%. Comparing base (8016726) to head (9318c0b).

Files Patch % Lines
pypesto/objective/amici/amici.py 0.00% 1 Missing ⚠️
pypesto/objective/amici/amici_calculator.py 66.66% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1344      +/-   ##
===========================================
- Coverage    84.28%   84.26%   -0.03%     
===========================================
  Files          152      152              
  Lines        12441    12441              
===========================================
- Hits         10486    10483       -3     
- Misses        1955     1958       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PaulJonasJost PaulJonasJost marked this pull request as ready for review March 28, 2024 15:03
@PaulJonasJost PaulJonasJost merged commit f418577 into develop Mar 29, 2024
18 checks passed
@PaulJonasJost PaulJonasJost deleted the another_amici_depracation branch March 29, 2024 18:39
@PaulJonasJost PaulJonasJost mentioned this pull request Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants