Removing Benchmark collection for deploy. Update action versions. #1371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #1371 +/- ##
============================================
- Coverage 84.47% 53.69% -30.78%
============================================
Files 157 157
Lines 12917 12917
============================================
- Hits 10911 6936 -3975
- Misses 2006 5981 +3975 ☔ View full report in Codecov by Sentry. |
dweindl
approved these changes
Apr 15, 2024
dweindl
reviewed
Apr 15, 2024
| - name: Remove direct dependencies from setup.cfg | ||
| # Remove any "git+https"-based dependencies that are not supported | ||
| # by PyPI and are only required for testing. | ||
| run: sed -i '/git+https/d' python/sdist/setup.cfg |
There was a problem hiding this comment.
Oops. Should be run: sed -i '/git+https/d' setup.cfg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deploy did not work due to the benchmark collection being a direct link