Relative: fix log of zero for default 0 sigma values #1377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #1377 +/- ##
============================================
- Coverage 84.41% 53.72% -30.69%
============================================
Files 157 157
Lines 12919 12928 +9
============================================
- Hits 10905 6946 -3959
- Misses 2014 5982 +3968 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an observable has hierarchical noise, but has no measurement at some simulation timepoint for which the model is simulated, then the
edata.getObservedDatawill benanbut therdata.sigmayfor that condition, observable and timepoint will be 0.This was causing an issue in the direct calculation of the NLLH as we were taking the
log(2 * np.pi * sigma_i**2)wheresigma_iwasrdata.sigmay. This gaveRuntimeWarning: divide by zero encountered in logerrors.The fix is simple: mask the
sigma_iarray with the mask for which the data is notnan. Already available inproblem.data_mask.Was raised in issue #1375