Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More detailed defaults for problem.get_full_vector #1393

Merged
merged 6 commits into from
May 14, 2024

Conversation

PaulJonasJost
Copy link
Collaborator

As the doctoring already explained before, we usually want problem.x_fixed_vals as defaults if we update a vector x. I think this should be a default and leaving the nans should be left for gradients (hence another parameter to distinguish the two.

@PaulJonasJost PaulJonasJost self-assigned this May 5, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.52%. Comparing base (18be6e3) to head (c97d36c).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1393      +/-   ##
===========================================
+ Coverage    84.50%   84.52%   +0.02%     
===========================================
  Files          157      157              
  Lines        12955    12958       +3     
===========================================
+ Hits         10947    10953       +6     
+ Misses        2008     2005       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Doresic Doresic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Makes more sense for the default to grab problem.x_fixed_vals instead of not using them.

pypesto/problem/base.py Outdated Show resolved Hide resolved
pypesto/problem/base.py Outdated Show resolved Hide resolved
pypesto/problem/base.py Outdated Show resolved Hide resolved
Copy link
Contributor

@m-philipps m-philipps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I left an optional suggestion to extend on the docstring.

@PaulJonasJost PaulJonasJost merged commit 9d5c13b into develop May 14, 2024
18 checks passed
@PaulJonasJost PaulJonasJost deleted the problem_get_full_vector branch May 14, 2024 07:53
This was referenced May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants