Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JaxObjective #1400

Merged
merged 10 commits into from
May 29, 2024
Merged

Fix JaxObjective #1400

merged 10 commits into from
May 29, 2024

Conversation

GiacomoFabrini
Copy link
Contributor

  • Add pre_post_processor.setter
  • Add base_objective wrapper functions (value / value and grad) to JaxObjective

@codecov-commenter
Copy link

codecov-commenter commented May 15, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 68.99%. Comparing base (d8333bd) to head (f883f01).

Files Patch % Lines
pypesto/objective/jax/base.py 90.90% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1400       +/-   ##
===========================================
- Coverage   84.48%   68.99%   -15.50%     
===========================================
  Files         157      157               
  Lines       12917    12927       +10     
===========================================
- Hits        10913     8919     -1994     
- Misses       2004     4008     +2004     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dweindl dweindl changed the base branch from main to develop May 22, 2024 17:37
PaulJonasJost added a commit that referenced this pull request May 29, 2024
pypesto/objective/jax/base.py Show resolved Hide resolved
test/base/test_objective.py Show resolved Hide resolved
@FFroehlich FFroehlich merged commit 0b8417f into ICB-DCM:develop May 29, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants