Fixing some warnings #1430
Merged
Fixing some warnings #1430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #1430 +/- ##
===========================================
- Coverage 83.34% 83.32% -0.02%
===========================================
Files 161 161
Lines 13243 13247 +4
===========================================
+ Hits 11037 11038 +1
- Misses 2206 2209 +3 ☔ View full report in Codecov by Sentry. |
PaulJonasJost
requested review from
m-philipps,
dilpath,
vwiela,
dweindl and
Doresic
as code owners
|
Decreased from base: 570 to 68 warnings for now |
dweindl
reviewed
Aug 1, 2024
Comment on lines
-124
to
+123
| warnings.warn( | ||
| logger.debug( |
There was a problem hiding this comment.
Using warnings here was intended to make it easier to disable those, see #1253
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of which warnings should be removed in commit messages