Fix set of keys to aggregate results #883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #883 +/- ##
============================================
- Coverage 88.33% 51.82% -36.52%
============================================
Files 106 106
Lines 7580 7580
============================================
- Hits 6696 3928 -2768
- Misses 884 3652 +2768
Continue to review full report at Codecov.
|
FFroehlich
approved these changes
Jul 4, 2022
Co-authored-by: Fabian Fröhlich <fabian_froehlich@hms.harvard.edu>
dweindl
reviewed
Jul 6, 2022
Co-authored-by: Daniel Weindl <dweindl@users.noreply.github.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling an
AmiciObjectivewithsensi-order=(1,)returns a dictionary with keysfval, radta, grad, but apypesto.Objectivewill just return a dictionary with keysgrad. So an aggregated objective build by a combination of both will fail if called withsensi-orders=(1,), if theAmici.Objectiveis the first partial objective. This also means the.get_gradfunction will fail and one cannot perfom optimization.This can be fixed by taking the intersection of the keys of all results instead of just taking the keys of the first partial objective.