Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky test CRFunModeHistoryTest.test_trace_all #917

Merged
merged 5 commits into from
Aug 12, 2022

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Aug 8, 2022

The previous check did not handle large values too well. Failed here: https://github.com/ICB-DCM/pyPESTO/runs/7724332758?check_suite_focus=true

@codecov-commenter
Copy link

codecov-commenter commented Aug 12, 2022

Codecov Report

Merging #917 (af6c828) into develop (b1242c3) will increase coverage by 4.23%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #917      +/-   ##
===========================================
+ Coverage    84.05%   88.29%   +4.23%     
===========================================
  Files          114      114              
  Lines         7766     7766              
===========================================
+ Hits          6528     6857     +329     
+ Misses        1238      909     -329     
Impacted Files Coverage Δ
pypesto/store/save_to_hdf5.py 96.82% <0.00%> (+1.58%) ⬆️
pypesto/store/hdf5.py 95.83% <0.00%> (+12.50%) ⬆️
pypesto/select/__init__.py 66.66% <0.00%> (+66.66%) ⬆️
pypesto/select/model_problem.py 90.38% <0.00%> (+90.38%) ⬆️
pypesto/select/method.py 92.91% <0.00%> (+92.91%) ⬆️
pypesto/visualize/select.py 93.33% <0.00%> (+93.33%) ⬆️
pypesto/select/misc.py 100.00% <0.00%> (+100.00%) ⬆️
pypesto/select/problem.py 100.00% <0.00%> (+100.00%) ⬆️
pypesto/select/postprocessors.py 100.00% <0.00%> (+100.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dweindl dweindl merged commit 7ac4f8f into develop Aug 12, 2022
@dweindl dweindl deleted the fix_test_trace_all branch August 12, 2022 12:08
Copy link
Member

@yannikschaelte yannikschaelte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@PaulJonasJost PaulJonasJost mentioned this pull request Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants