Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ipopt 3.14 #6

Closed
wants to merge 553 commits into from
Closed

Ipopt 3.14 #6

wants to merge 553 commits into from

Conversation

Robbybp
Copy link
Member

@Robbybp Robbybp commented Oct 9, 2023

I just merged coin-or:stable/3.14 into our stable/idaes-3.13 branch. I'd like to create this as a new branch on this fork, but it seems I can't do that with a PR.

svigerske added 30 commits May 4, 2021 16:58
- I guess the --vec_vals was meant for the following loop
- add some asserts to prevent null-pointer-dereference warnings
- return on some functions early if working on empty vector/matrix
- throw exception if ampl suffixes wrong
- etc
- join makefiles and skip static non-distributed libraries
- remove IPALLLIBS
- remove duplicate am_conditional
- so show more officially that we assume that Fortran INTEGER is the same
  as C int
- some of them don't compile and I don't think they would support 64bit
  integers
- for hs071_f test and example
- pardiso-project's pardiso doesn't seem to have an option to switch to
  64-bit integers nor does it look as if they had separate libs for that
svigerske and others added 23 commits August 30, 2022 12:25
- to avoid some confusion with smaller Archive link on left side, see
  coin-or-tools/ThirdParty-HSL#15
- ... when warmstart with same structure and grad_f_constant is set
- need to get new gradient value still, as coefs may have changed for new
  solve
- many thanks to @fschloesser on helping to figure these out
In the commented out code for writing the solution to a file, the third index is missing. Just adding it here.
- autoconf-archive 2021.02.19 -> 2022.09.03
- automake 1.16.3 -> 1.16.5
- libtool 2.4.6 -> 2.4.7
- for users that want to provide their own linear solver interface
- fixes coin-or#637
- CSR_Format gives the upper triangular matrix, not the lower
- see coin-or#638
- triplet gives lower diagonal, but CSR gives upper diagonal
- see also coin-or#638
- These headers are required to use custom linear
  solvers on the user side.
- Fixes coin-or#618, coin-or#637, coin-or#641.
@ksbeattie ksbeattie added the question Further information is requested label Oct 26, 2023
@ksbeattie ksbeattie added the Priority:Normal Normal Priority Issue or PR label Oct 26, 2023
@ksbeattie
Copy link
Member

@Robbybp let me know if you need more permissions to create a branch or merge this.

@Robbybp
Copy link
Member Author

Robbybp commented Nov 3, 2023

Something is wrong with this branch. The IDAES-Ipopt copyright header is not present in the print_copyright_message function in scr/Algorithm/IpIpoptAlg.cpp. The correct copyright header is in the stable/idaes-3.13 branch here. Maybe I didn't actually merge into this branch?

I will close this PR in favor of working out exactly what needs to be done on the issue IDAES/idaes-pse#1248, then will request the required permissions to do this.

@Robbybp Robbybp closed this Nov 3, 2023
@Robbybp Robbybp deleted the stable/idaes-3.14 branch December 14, 2023 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:Normal Normal Priority Issue or PR question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants