Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit "upadate" in typos list and code #1444

Closed
bpaul4 opened this issue Jul 3, 2024 · 3 comments
Closed

Revisit "upadate" in typos list and code #1444

bpaul4 opened this issue Jul 3, 2024 · 3 comments
Assignees
Labels
Priority:Normal Normal Priority Issue or PR

Comments

@bpaul4
Copy link
Contributor

bpaul4 commented Jul 3, 2024

Currently, "upadate" is an exception to the spell checker due to what looks like a temporary fix for DMF examples: https://github.com/search?q=org%3AIDAES%20upadate&type=code

At a convenient time, we should consider correcting "upadate_metadata_model_references" back to "update_metadata_model_references" in the code and examples, and clean up as needed.

@ksbeattie ksbeattie added the Priority:Normal Normal Priority Issue or PR label Jul 11, 2024
@bpaul4
Copy link
Contributor Author

bpaul4 commented Aug 5, 2024

@dangunter what is the status regarding DMF support? If the plan is to continue supporting the tool, I am happy to open a pull request to correct the typo and remove the exception.

For what it's worth, it appears the typo was "corrected" in the two DMF examples https://github.com/IDAES/examples/blob/main/idaes_examples/archive/data_reconciliation/boiler_flowsheet_recon_src.ipynb and https://github.com/IDAES/examples/blob/main/idaes_examples/archive/data_reconciliation/econ_recon_src.ipynb. The notebooks are not currently tested, but most likely would fail since they reference update_metadata_model_references not upadate_metadata_model_references as currently exists in the code.

@dangunter
Copy link
Member

The DMF is being removed, so I don't think it is worth correcting this typo

@lbianchi-lbl
Copy link
Contributor

Resolved by #1484

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:Normal Normal Priority Issue or PR
Projects
None yet
Development

No branches or pull requests

4 participants