-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove idaes.core.dmf and related code #1484
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1484 +/- ##
==========================================
+ Coverage 76.37% 76.83% +0.46%
==========================================
Files 393 376 -17
Lines 65086 61087 -3999
Branches 14426 13504 -922
==========================================
- Hits 49708 46939 -2769
+ Misses 12816 11767 -1049
+ Partials 2562 2381 -181 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The exceptions, deletions, and changes look good to me.
Resolves #1368
Changes proposed in this PR:
idaes/core/dmf
idaes/core/dmf/__init__.py
to add deprecation to be shown when importingidaes.core.dmf
setup.py
dmf_data
directoryTo review
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: