Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove idaes.core.dmf and related code #1484

Merged
merged 21 commits into from
Sep 6, 2024

Conversation

lbianchi-lbl
Copy link
Contributor

@lbianchi-lbl lbianchi-lbl commented Sep 5, 2024

Resolves #1368

Changes proposed in this PR:

  • Remove most files in idaes/core/dmf
  • Edit idaes/core/dmf/__init__.py to add deprecation to be shown when importing idaes.core.dmf
  • Trim logic used to skip tests that need optional dependencies
  • Remove code that was only used for DMF from setup.py
  • Remove dmf_data directory

To review

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@lbianchi-lbl lbianchi-lbl self-assigned this Sep 5, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 5, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 76.83%. Comparing base (8140a3d) to head (2b8bc8b).
Report is 26 commits behind head on main.

Files with missing lines Patch % Lines
idaes/core/dmf/__init__.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1484      +/-   ##
==========================================
+ Coverage   76.37%   76.83%   +0.46%     
==========================================
  Files         393      376      -17     
  Lines       65086    61087    -3999     
  Branches    14426    13504     -922     
==========================================
- Hits        49708    46939    -2769     
+ Misses      12816    11767    -1049     
+ Partials     2562     2381     -181     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@bpaul4 bpaul4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The exceptions, deletions, and changes look good to me.

@lbianchi-lbl lbianchi-lbl added the CI:run-integration triggers_workflow: Integration label Sep 6, 2024
@idaes-build idaes-build removed the CI:run-integration triggers_workflow: Integration label Sep 6, 2024
@lbianchi-lbl lbianchi-lbl merged commit cd56535 into IDAES:main Sep 6, 2024
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:High High Priority Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DMF retirement
5 participants