-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate old Cubic EoS #1519
Deprecate old Cubic EoS #1519
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1519 +/- ##
==========================================
- Coverage 77.05% 77.04% -0.01%
==========================================
Files 384 384
Lines 62335 62338 +3
Branches 10222 10222
==========================================
Hits 48031 48031
- Misses 11875 11879 +4
+ Partials 2429 2428 -1 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK to me - just to confirm, have you checked the examples to make sure there is nothing there that depends on this?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, @dallan-keylogic.
docs/reference_guides/model_libraries/generic/property_models/ceos.rst
Outdated
Show resolved
Hide resolved
Got a test failure on Python 3.10 Windows, completely unrelated to the PR.
|
@dallan-keylogic That is a known ongoing but intermittent issue. The plotting tests really need to be revisited to see if there is anything we can actually test - at the moment they just test that the code executes with no failures, but occasionally it results in errors like this. |
@dallan-keylogic for reference, the issue @andrewlee94 is referring to is #1453. |
The Codecov upload failures are due to codecov/feedback#577, which should now be fixed. |
Summary/Motivation:
The old cubic equation of state has not been updated to have correct formulae for partial molar Gibbs and Helmholtz free energy, and doesn't have any formulae for heat capacity or speed of sound. Since it's been made obsolete by the cubic EoS implemented through the Modular Property Framework, there's no reason to keep it around to confuse people.
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: