Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI changes for diagnostics master issue #42

Closed
8 of 11 tasks
dangunter opened this issue Dec 15, 2023 · 3 comments
Closed
8 of 11 tasks

UI changes for diagnostics master issue #42

dangunter opened this issue Dec 15, 2023 · 3 comments
Assignees
Labels
Priority:High High Priority Issue or PR

Comments

@dangunter
Copy link
Member

dangunter commented Dec 15, 2023

This issue provides a list of tasks for implementing the new design expressed in mockups (attached).
The list of tasks may grow and change. They are listed here in order of operations (i.e. do the first one first).
Please create PRs for each, add the number, and check off when merged.

  • Rewrite backend API tests for FastAPI Sheng: WIP (Move server to fastapi #43)
  • Create smoke tests that operate on the header area of the page
  • Add react mosaic (RM) to make panel layout flexible (GL dropped react support) *Sheng: WIP *
  • Add tests for RM
  • Add diagnostics panel with structural issues tab (only), no "suggested next steps" Sheng: WIP (Add diagnostics #34)

target for Jan 30th meeting


  • Add numerical issues tab to diagnostics panel, no suggested next steps
  • Add suggested next steps APIs and tests
  • Add suggested next steps output panel, and links in both structural issues and numerical issues panels
  • Add side panel with unit performance information
  • Add "brushing" between diagram and diagnostics - re-run diagnostics on selected unit
  • Add "brushing" between diagram/diagnostics/side panel with unit info

Flowsheet Visualizer Mockups (1)

@ksbeattie ksbeattie added the Priority:High High Priority Issue or PR label Dec 21, 2023
@CopyDemon
Copy link
Contributor

FastAPI main feature is finished, and working now, try to fix the CI workflow file to let GitHub trigger the CI correctly.

@CopyDemon
Copy link
Contributor

Display config and diagnostics result functions have finished on PR #34 Try to find the "suggested next step" data in the diagnostics JSON.

@CopyDemon
Copy link
Contributor

Golden layout is dropped react support, Golden dropped feature doc

Now find an alternative layout manager:
react-mosaic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:High High Priority Issue or PR
Projects
None yet
Development

No branches or pull requests

3 participants