-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move server to fastapi #43
Conversation
…atic folder, add fn can open browser after 1.5 s delay after uvicorn runs
…save time interval or set as default 500
…f in jupyter if true add patch nest_asyncio
…s been deprecated. Use DataFrame.map instead.'
…le hide btn and minimize btn
…in and zoom out values to become excessively large due to duplicate event calls.
I'm sorry but I think we have to put this on the shelf for now. This is way too much code and way too complex for what it needs to do, and I don't want to get stuck maintaining it. We really need to let Uvicorn and FastAPI do all the work, and currently there are just a lot of classes and code that is duplicating what they can do. I know it will be a pain, but can you port over anything you changed here that you need for diagnostics, etc., back into the current "SimpleHTTPServer" framework. I can look at this later when I have a chance and see if I can get a skeleton working. |
sure, let me update the PR add diagnostics and roll back to SimpleHTTPServer. |
Thanks! Would it be easier to start a new PR so we don't have to delete all the additional things from this one? |
@dangunter I'll close this PR and roll back the fastAPI changes from PR #34. The PR 34 will only contain add diagnostics and it's new simpleHTTPServer backend. |
Fixes
Proposed changes:
move UI from old HTTP server to Fastapi server
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: