Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move server to fastapi #43

Closed
wants to merge 244 commits into from
Closed

Conversation

CopyDemon
Copy link
Contributor

Fixes

Proposed changes:
move UI from old HTTP server to Fastapi server

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

…atic folder, add fn can open browser after 1.5 s delay after uvicorn runs
…s been deprecated. Use DataFrame.map instead.'
@CopyDemon CopyDemon marked this pull request as ready for review March 7, 2024 21:00
@dangunter
Copy link
Member

I'm sorry but I think we have to put this on the shelf for now. This is way too much code and way too complex for what it needs to do, and I don't want to get stuck maintaining it. We really need to let Uvicorn and FastAPI do all the work, and currently there are just a lot of classes and code that is duplicating what they can do. I know it will be a pain, but can you port over anything you changed here that you need for diagnostics, etc., back into the current "SimpleHTTPServer" framework. I can look at this later when I have a chance and see if I can get a skeleton working.

@CopyDemon
Copy link
Contributor Author

sure, let me update the PR add diagnostics and roll back to SimpleHTTPServer.

@dangunter
Copy link
Member

Thanks! Would it be easier to start a new PR so we don't have to delete all the additional things from this one?

@CopyDemon
Copy link
Contributor Author

@dangunter I'll close this PR and roll back the fastAPI changes from PR #34. The PR 34 will only contain add diagnostics and it's new simpleHTTPServer backend.

@CopyDemon CopyDemon closed this Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:Normal Normal Priority Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants