Code

Issue 45 send back diagram image#51

Code

Open

CopyDemon wants to merge 74 commits intoIDAES:mainIDAES/idaes-ui:mainfrom CopyDemon:issue-45-send-back-diagram-imageCopyDemon/idaes-ui:issue-45-send-back-diagram-imageCopy head branch name to clipboard

+1,986-510

Commits

Commits on Aug 6, 2024

• add packages to get screenshot from live server

  CopyDemon

  committed
  e9c2a90

Commits on Aug 7, 2024

• add new function to return screenshot work save

  CopyDemon

  committed
  64a347b

Commits on Aug 21, 2024

• update save diagram function with async playwright, add save path validation

  CopyDemon

  committed
  5721b6c

• react build

  CopyDemon

  committed
  6bdb1cf

• add id for download Icon to let playwright to select to hover

  CopyDemon

  committed
  72d9faa

• ignore this, this is format

  CopyDemon

  committed
  aa648f0

Commits on Sep 4, 2024

• add test for save svg and png

  CopyDemon

  committed
  b351971

Commits on Sep 7, 2024

• internal function save diagram should return diagram saved path for pytest

  CopyDemon

  committed
  210a1a0

• add test diagram save path, work save now test default path

  CopyDemon

  committed
  889da65

Commits on Sep 9, 2024

• add testing test save path

  CopyDemon

  committed
  17f8851

• add return for test, add if condation to log info to user about path is invalid, add description to function

  CopyDemon

  committed
  16f872f

Commits on Sep 10, 2024

• update package list now only use playwright and nest_asyncio these are require for test and generate screenshot move to pyproject remove from requirement-dev

  CopyDemon

  committed
  c04feba

• add Ipython to dependency for only return screenshot to user when user at jupyter env other env will save image not display

  CopyDemon

  committed
  940c248

• grammar error fix

  CopyDemon

  committed
  18a5a33

• remove dependency fastapi uvicorn since these are not use

  CopyDemon

  committed
  5efba61

• move playwright to required dependency

  CopyDemon

  committed
  f562744

• add install playwright step for CI

  CopyDemon

  committed
  9d803f4

• testing CI is not install playwright

  CopyDemon

  committed
  b5660f1

• move install playwright to core test why playwright is not installed

  CopyDemon

  committed
  aa904a0

• remove logging capture since not in use, and add log for save path assert

  CopyDemon

  committed
  a045dc4

• update CI core add - name: Install playwright

  Show description for f26e529
  CopyDemon

  committed
  f26e529

• update default path defination, it defined within fsvis _validate_and_create_save_path()

  CopyDemon

  committed
  eced697

• update default path defination, it defined within fsvis _validate_and_create_save_path()

  CopyDemon

  committed
  14b0ee5

• _validate_and_create_save_path()now return default path for future use and test use

  CopyDemon

  committed
  7b22859

• windows show cant move file error and async_save_diagram function return none type, try to catch error and also return a file path

  CopyDemon

  committed
  5ccccbc

• use shutil replate os.rename in windows the os.rename is not working with move file from one disk to another

  CopyDemon

  committed
  efb183d

• insted of os.rename or shutil.move now use read and write file to save path to prevent error in change disk in windows, give a try

  CopyDemon

  committed
  89ba63e

• use platfrom and tempfile to create invalid path for windows and linux

  CopyDemon

  committed
  d026bf1

• add function arg description. add if condation default browser download path has screenshot file then remove it

  CopyDemon

  committed
  5550b3b

• debug: try remove delete folder code to see if that broken download

  CopyDemon

  committed
  89d3ec8

• increase waiting time for browser to fully load and restore delete download file in download folder sames like only bug on windows CI

  CopyDemon

  committed
  4f799c5

• continue increase browser waiting time for windows CI

  CopyDemon

  committed
  c07a712

• update browser use no sandbox mode

  CopyDemon

  committed
  3be7cb1

• debug update invalid path on window the CON:\ sames like can cause some problem

  CopyDemon

  committed
  8403abe

Commits on Oct 16, 2024

• update pint version 0.25, the idaes-pse 2.7.0.dev0 require 0.24.1

  CopyDemon

  committed
  8393687

• add utility tool use for cleanup screenshot folder

  CopyDemon

  committed
  298a4f3

• merge main branch

  CopyDemon

  committed
  4cc93c6

• replace f string path with os.path.join to avoid windows \ path is different linux or unix / path issue

  CopyDemon

  committed
  5f49e0f

• cleanup make less code but same function, add cleanup screenshot file function

  CopyDemon

  committed
  8ab01c3

• fix another windows invalid path by using os.path.join

  CopyDemon

  committed
  e7f13d8

Commits on Oct 22, 2024

• increase timeout time

  CopyDemon

  committed
  30c2157

Commits on Oct 23, 2024

• add timeout for playwright load page, click and download to avoid CI slow timeout issue

  CopyDemon

  committed
  93a458a

• revert timeout only left on load page and button click and test

  CopyDemon

  committed
  5aa3e7f

• increase timeout

  CopyDemon

  committed
  19bdabb

• move import to top then use async playwright instead of sync playwright

  CopyDemon

  committed
  2b24093

• max timeout 30s or it doesn't make sense

  CopyDemon

  committed
  a96ca43

• add log to notice user what is timeout doing when they download image

  CopyDemon

  committed
  7392b80

• try new timeout 30000

  CopyDemon

  committed
  cad9034

Commits on Oct 30, 2024

• test, remove timeout

  CopyDemon

  committed
  b25b1c7

• remove test generated files

  CopyDemon

  committed
  fc5c08a

• add test generated files to ignore

  CopyDemon

  committed
  7e5a838

• update add test_diagram.json to ignore ... spell wrong

  CopyDemon

  committed
  8cfcff3

• update CI add pytest-asyncio for test async function

  CopyDemon

  committed
  150fac4

• update pytest screenshot

  CopyDemon

  committed
  c422f05

• fix wrong way to add timeout

  CopyDemon

  committed
  a651075

• move save diagram screen to it's own file own class make sure fsvis is clean

  CopyDemon

  committed
  e7c1cf2

• update param in test

  CopyDemon

  committed
  28ec442

• make sure playwright browser is headless

  CopyDemon

  committed
  c0d98cf

• add comment to save diagram function self

  CopyDemon

  committed
  c6e4838

Commits on Dec 3, 2024

• use idaes >= 2.7.0

  CopyDemon

  committed
  0963887

• Merge branch 'main' into issue-45-send-back-diagram-image

  CopyDemon

  authored
  48daef7

Commits on Dec 4, 2024

• added export_flowsheet_diagram function

  dangunter

  committed
  13ef471

Commits on Dec 5, 2024

• tests for export_flowsheet_diagram

  dangunter

  committed
  7ffe80b

Commits on Dec 12, 2024

• move returns back to try block not in finally

  CopyDemon

  committed
  cdb7010

• remove close loop it will make upcoming test fail, and update bytes size is 10 better?

  CopyDemon

  committed
  6bc4e05

• close the diagnostc test, the IDAES 2.7 has some changes that make diagnostics on UI is not working address this issue with another ticket

  CopyDemon

  committed
  3f6a28d

Commits on Dec 19, 2024

• roll idaes-pse version back to git repo main

  CopyDemon

  committed
  0aeb041

• instead of store visualize result as dict then call .save_diagram, directly call it prevent 'the loop_forever not call and server not up issue'

  CopyDemon

  committed
  70c9fa0

• remove the async test, restore integration

  CopyDemon

  committed
  92d17ac

• replace the save path test with test_export_flowsheet_diagram

  CopyDemon

  committed
  615bdc3

• update IO or OS error base on windows or linux

  CopyDemon

  committed
  af93331

• try just use oserror

  CopyDemon

  committed
  eff594d

• take both OSError and IOError because window will try to create on root folder

  CopyDemon

  committed
  195fdbc

• windows continue fail on this test try to check how windows will show error

  CopyDemon

  committed
  ade46ca