Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protocol-Independent Cross-Origin Discovery Flow #2

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

hlflanagan
Copy link

Attempting to capture the multilateral federation use case, specifically around WAYF services.

Comment on lines 23 to 27
- 1st party Cookie
- 3rd party cookies
- Redirect with link decoration
- Persistent Local Storage
- cross-domain postMessage
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to highlight in the 'Description of flow' section how each of these are used? The use of local storage is already well described. I think it would be helpful for the scenario to highlight how 3rd party cookies are required as well as cross-domain postMessage.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I went overboard with the pieces that are required for this specific use case. I've updated the file and updated the drawings to try and be more clear about exactly what/where the different components interact with browser features.

Updated required features, updated link to diagram
removing any protocol dependencies; added a better sequence diagram link to the description of the flow
@hlflanagan hlflanagan changed the title Create MultilateralFederation.md Protocol-Independent Cross-Origin Discovery Flow Mar 24, 2021
### Description Of The Flow
A full design of the data flows used to support a central discovery service are available here: <https://docs.google.com/presentation/d/1h3XQ6BtTQ7KJkBQkIkWjktp3RXqHDXEKsa5ymrjzA-k/edit#slide=id.p>

This flow writes to browser local storage via a dedicated component which loads a non-displayed iFrame.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great if there could be a bit more detail around how the iframe interacts with the local storage and where the iframe is embedded.

Less important: I'd prefer the seq diag to be included (I just added one to my scenario using the Online Server of https://plantuml.com/).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants