Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email Implementation on local units #2357

Merged
merged 19 commits into from
Dec 31, 2024
Merged

Conversation

susilnem
Copy link
Member

Addresses

Changes

  • Commenting out tls server for now
  • Email Implementation on Local units
  • Create a Cronjob for sending email to Regional and global validators

Checklist

Things that should succeed before merging.

  • Updated/ran unit tests
  • Updated CHANGELOG.md

Release

If there is a version update, make sure to tag the repository with the latest version.

@susilnem susilnem requested review from Rup-Narayan-Rajbanshi and thenav56 and removed request for Rup-Narayan-Rajbanshi December 27, 2024 08:32
notifications/templates/email/local_units/local_unit.html Outdated Show resolved Hide resolved
notifications/templates/email/local_units/local_unit.html Outdated Show resolved Hide resolved

{% endif %}

{% if global_admin %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if the variable name is correct here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are passed through context variable from this file local_units/management/commands/notify_validators.py

notifications/notification.py Outdated Show resolved Hide resolved
local_units/management/commands/notify_validators.py Outdated Show resolved Hide resolved
local_units/management/commands/notify_validators.py Outdated Show resolved Hide resolved
local_units/tasks.py Outdated Show resolved Hide resolved
local_units/tasks.py Outdated Show resolved Hide resolved
local_units/tasks.py Outdated Show resolved Hide resolved
local_units/utils.py Show resolved Hide resolved
local_units/views.py Outdated Show resolved Hide resolved

{% endif %}

{% if global_admin %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are passed through context variable from this file local_units/management/commands/notify_validators.py

notifications/templates/email/local_units/local_unit.html Outdated Show resolved Hide resolved
notifications/templates/email/local_units/local_unit.html Outdated Show resolved Hide resolved
local_units/tasks.py Outdated Show resolved Hide resolved
local_units/tasks.py Outdated Show resolved Hide resolved
local_units/utils.py Outdated Show resolved Hide resolved
local_units/tasks.py Outdated Show resolved Hide resolved
local_units/views.py Outdated Show resolved Hide resolved
local_units/dev_views.py Outdated Show resolved Hide resolved
@thenav56 thenav56 merged commit bd86984 into project/localunit Dec 31, 2024
3 checks passed
@thenav56 thenav56 deleted the feature/localunit-email branch December 31, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants