Add isLocked check for the edit dropdown in table action

IFRCGo · Dec 18, 2024 · 285dbd7 · 285dbd7
1 parent fc7e9a5
commit 285dbd7
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 14 deletions.
diff --git a/...ontextAndStructure/NationalSocietyLocalUnits/LocalUnitsFormModal/LocalUnitsForm/i18n.json b/...ontextAndStructure/NationalSocietyLocalUnits/LocalUnitsFormModal/LocalUnitsForm/i18n.json
@@ -5,7 +5,7 @@
         "successMessage": "Local unit added successfully!",
         "revertChangesSuccessMessage": "Local unit reverted successfully!",
         "failedMessage": "Failed to add local unit",
-        "revertChangesFailedMessage": "Failed to revert changes in local unit",
+        "revertChangesFailedMessage": "Failed to revert changes in the local unit",
         "updateMessage": "Local unit updated successfully!",
         "updateFailedMessage": "Failed to update local unit",
         "specialitiesAndCapacityTitle": "Specialities & Capacity",

diff --git a/...ontextAndStructure/NationalSocietyLocalUnits/LocalUnitsFormModal/LocalUnitsForm/index.tsx b/...ontextAndStructure/NationalSocietyLocalUnits/LocalUnitsFormModal/LocalUnitsForm/index.tsx
@@ -427,7 +427,7 @@ function LocalUnitsForm(props: Props) {
 
     const readOnly = readOnlyFromProps
         || isNotDefined(localUnitDetailsResponse)
-        || localUnitDetailsResponse?.is_locked;
+        || localUnitDetailsResponse.is_locked;
 
     const {
         response: localUnitsOptions,
@@ -640,9 +640,8 @@ function LocalUnitsForm(props: Props) {
 
     return (
         <div className={styles.localUnitsForm}>
-            {!localUnitDetailsResponse?.is_locked
-                && readOnlyFromProps
-                && isNotDefined(localUnitDetailsResponse)
+            {isDefined(localUnitDetailsResponse)
+                && !readOnly
                 && isDefined(actionsContainerRef.current) && (
                 <Portal container={actionsContainerRef.current}>
                     {(environment !== 'production') && (
@@ -748,7 +747,7 @@ function LocalUnitsForm(props: Props) {
                                                 readOnly={!pristine}
                                             />
                                         )}
-                                        {localUnitDetailsResponse?.is_locked && (
+                                        {localUnitDetailsResponse.is_locked && (
                                             <Button
                                                 name={undefined}
                                                 onClick={setShowRevertChangesModalTrue}

diff --git a/...extAndStructure/NationalSocietyLocalUnits/LocalUnitsTable/LocalUnitTableActions/index.tsx b/...extAndStructure/NationalSocietyLocalUnits/LocalUnitsTable/LocalUnitTableActions/index.tsx
@@ -30,6 +30,7 @@ export interface Props {
     isValidated: boolean;
     onDeleteActionSuccess: () => void;
     onValidationActionSuccess: () => void;
+    isLocked: boolean;
 }
 
 function LocalUnitsTableActions(props: Props) {
@@ -40,6 +41,7 @@ function LocalUnitsTableActions(props: Props) {
         isValidated,
         onValidationActionSuccess,
         onDeleteActionSuccess,
+        isLocked,
     } = props;
 
     const strings = useTranslation(i18n);
@@ -120,14 +122,6 @@ function LocalUnitsTableActions(props: Props) {
                         >
                             {strings.localUnitsView}
                         </DropdownMenuItem>
-                        <DropdownMenuItem
-                            type="button"
-                            name={localUnitId}
-                            onClick={handleEditLocalUnitClick}
-                            disabled={isGuestUser}
-                        >
-                            {strings.localUnitsEdit}
-                        </DropdownMenuItem>
                         {hasDeletePermission && (
                             <DropdownMenuItem
                                 type="button"
@@ -137,6 +131,16 @@ function LocalUnitsTableActions(props: Props) {
                                 {strings.localUnitsDelete}
                             </DropdownMenuItem>
                         )}
+                        {!isLocked && (
+                            <DropdownMenuItem
+                                type="button"
+                                name={localUnitId}
+                                onClick={handleEditLocalUnitClick}
+                                disabled={isGuestUser}
+                            >
+                                {strings.localUnitsEdit}
+                            </DropdownMenuItem>
+                        )}
                     </>
                 )}
             >
@@ -153,6 +157,7 @@ function LocalUnitsTableActions(props: Props) {
                         name={localUnitId}
                         variant="tertiary"
                         onClick={handleViewLocalUnitClick}
+                        disabled={isGuestUser}
                     >
                         {strings.localUnitsView}
                     </Button>

diff --git a/.../CountryNsOverviewContextAndStructure/NationalSocietyLocalUnits/LocalUnitsTable/index.tsx b/.../CountryNsOverviewContextAndStructure/NationalSocietyLocalUnits/LocalUnitsTable/index.tsx
@@ -130,6 +130,7 @@ function LocalUnitsTable(props: Props) {
                     countryId: item.country,
                     localUnitId: item.id,
                     isValidated: item.validated,
+                    isLocked: item.is_locked,
                     localUnitName: getFirstTruthyString(
                         item.local_branch_name,
                         item.english_branch_name,