Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Local units delete modal #1587

Merged
merged 4 commits into from
Dec 17, 2024
Merged

Local units delete modal #1587

merged 4 commits into from
Dec 17, 2024

Conversation

shreeyash07
Copy link
Collaborator

Addresses:

Changes

  • Add modal for localunits deletion in localunit table and localunit form
  • Update delete localunits api

This PR doesn't introduce:

  • typos
  • conflict markers
  • unwanted comments
  • temporary files, auto-generated files or secret keys
  • console.log meant for debugging
  • codegen errors

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 13, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 3777ec2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@shreeyash07 shreeyash07 force-pushed the feature/delete-local-unit branch from 5541cb1 to 7a68dc0 Compare December 13, 2024 10:27
@shreeyash07 shreeyash07 force-pushed the feature/delete-local-unit branch from 7a68dc0 to d5e1c60 Compare December 16, 2024 06:33
@shreeyash07
Add localunits delete modal in
d5e1c60 
    - localunits Form
    - localunits table
@shreeyash07 shreeyash07 requested a review from tnagorra December 16, 2024 06:39
@samshara samshara changed the title Localunits delete modal Local units delete modal Dec 16, 2024
@samshara samshara requested a review from tnagorra December 17, 2024 04:06
@samshara samshara merged commit 2e3eb63 into project/local-unit-v2 Dec 17, 2024
9 of 10 checks passed
@samshara samshara deleted the feature/delete-local-unit branch December 17, 2024 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samshara samshara samshara approved these changes

@tnagorra tnagorra tnagorra approved these changes

@AdityaKhatri AdityaKhatri Awaiting requested review from AdityaKhatri

@barshathakuri barshathakuri Awaiting requested review from barshathakuri

Assignees

@samshara samshara

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shreeyash07 @tnagorra @samshara