Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix position of Rating dropdown in PER form #1591

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fix position of Rating dropdown in PER form #1591

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions app/src/views/PerAssessmentForm/AreaInput/ComponentInput/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,14 +187,14 @@ function ComponentInput(props: Props) {
)}
key={component.id}
heading={getComponentTitle(component)}
childrenContainerClassName={styles.questionList}
headerDescription={component.description}
headingClassName={styles.heading}
withInternalPadding
withoutWrapInHeading
spacing="comfortable"
headingDescriptionContainerClassName={styles.statusSelectionContainer}
/>
>
{component.description}
</Container>
);
}

Expand All @@ -203,10 +203,10 @@ function ComponentInput(props: Props) {
className={_cs(styles.componentInput, className)}
key={component.id}
heading={getComponentTitle(component)}
childrenContainerClassName={styles.questionList}
withHeaderBorder
headerDescription={component.description}
headingDescriptionContainerClassName={styles.statusSelectionContainer}
headingClassName={styles.heading}
headingContainerClassName={styles.headingContainer}
headingDescription={(
<SelectInput
readOnly={readOnly}
Expand All @@ -227,7 +227,7 @@ function ComponentInput(props: Props) {
showExpandButtonAtBottom
initiallyExpanded
contentViewType="vertical"
spacing="relaxed"
spacing="comfortable"
>
<NonFieldError error={error} />
<NonFieldError error={questionInputError} />
Expand Down
15 changes: 9 additions & 6 deletions app/src/views/PerAssessmentForm/AreaInput/ComponentInput/styles.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,17 @@
.component-input {
.heading-container {
@media screen and (max-width: 50rem) {
flex-wrap: wrap;
}
}

.heading {
flex-grow: 1;
}

.status-selection-container {
display: flex;

.status-selection {
width: 20rem;
}
.status-selection {
width: 100%;
max-width: 20rem;
}

.description {
Expand Down
Loading