Add national society indicators #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samshara
reviewed
Dec 26, 2023
src/views/CountryNsOverviewContextAndStructure/NationalSocietyIndicators/index.tsx
Outdated
Show resolved
Hide resolved
src/views/CountryNsOverviewContextAndStructure/NationalSocietyIndicators/index.tsx
Outdated
Show resolved
Hide resolved
src/views/CountryNsOverviewContextAndStructure/NationalSocietyIndicators/index.tsx
Outdated
Show resolved
Hide resolved
samshara
reviewed
Dec 27, 2023
src/views/CountryNsOverviewContextAndStructure/NationalSocietyIndicators/index.tsx
Outdated
Show resolved
Hide resolved
samshara
reviewed
Dec 27, 2023
Comment on lines
31
to
36
| const staffValue = sumSafe([ | ||
| indicatorResponse?.female_staff_total, | ||
| indicatorResponse?.male_staff_total, | ||
| ]); | ||
|
|
||
| const volunteersValue = sumSafe([ | ||
| indicatorResponse?.male_volunteer_total, | ||
| indicatorResponse?.female_volunteer_total, | ||
| ]); |
There was a problem hiding this comment.
we should use KPI_PStaff_Tot, KPI_PeopleVol_Tot indicators
There was a problem hiding this comment.
@samshara lets note that we are including 3rd gender population.
barshathakuri
force-pushed
the
feature/ns-indicators
branch
from
5be97a1 to
bdbd478
Compare
samshara
reviewed
Dec 28, 2023
Comment on lines
31
to
36
| const youthValue = sumSafe([ | ||
| indicatorResponse?.male_volunteer_age_6_12, | ||
| indicatorResponse?.male_volunteer_age_13_17, | ||
| indicatorResponse?.male_volunteer_age_18_29, | ||
| indicatorResponse?.female_volunteer_age_6_12, | ||
| indicatorResponse?.female_volunteer_age_13_17, | ||
| indicatorResponse?.female_volunteer_age_18_29, | ||
| indicatorResponse?.female_staff_age_18_29, | ||
| indicatorResponse?.male_staff_age_18_29, | ||
| ]); |
There was a problem hiding this comment.
As per previous discussions, we should use the total value.
cc: @k9845
Indicators to use
KPI_PeopleVol_Tot_age_6_12
KPI_PeopleVol_Tot_age_13_17
KPI_PeopleVol_Tot_age_18_29
`
samshara
force-pushed
the
project/country-pages
branch
from
d13ba59 to
77454de
Compare
barshathakuri
force-pushed
the
feature/ns-indicators
branch
from
4a893d3 to
2dcc3d3
Compare
barshathakuri
requested review from
utsukta1,
roshni73,
UjjwalDhakal7 and
fereeca
samshara
approved these changes
Jan 4, 2024
samshara
force-pushed
the
feature/ns-indicators
branch
from
f239df3 to
45a790a
Compare
samshara
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses:
Changes
This PR doesn't introduce:
console.logmeant for debugging