Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profiling of Bundle with PATCH #222 #227

Merged
merged 2 commits into from
May 7, 2024
Merged

Profiling of Bundle with PATCH #222 #227

merged 2 commits into from
May 7, 2024

Conversation

oliveregger
Copy link
Contributor

See #222

  • parameter.name = "operation" has generated a condition which applies to all Parameters, in that case also to the part parameter

to fix this:

  1. convert it to a slicing that it applies only to the toplevel name
  2. added subslice for the part.name, because it is know for the usecase what needs to be provided

the 2nd step is optional (from line 14 on), the error disappears alos with just slicing to line 13

@oliveregger
Copy link
Contributor Author

@JohnMoehrke
Copy link
Contributor

This capability is never explained. We should not have a capability that is only available if someone can understand the profiled artifacts.

@oliveregger
Copy link
Contributor Author

it is explained here: https://profiles.ihe.net/ITI/MHD/ITI-65.html#23654123-replace-transform-signs-and-append-associations
what do you think is missing?

@JohnMoehrke
Copy link
Contributor

JohnMoehrke commented May 5, 2024 via email

Copy link
Contributor

@JohnMoehrke JohnMoehrke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. Committee reviewed

@JohnMoehrke JohnMoehrke merged commit a1e1254 into master May 7, 2024
@JohnMoehrke JohnMoehrke deleted the oe_updatepatch branch May 7, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants