-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document Physical Dimensions extension #1358
Comments
Can we find someone other than an editor to do this, as an easy test run of submitting an extension to be registered? |
Here's a first pass at this: https://gist.github.com/workergnome/01a3c617b0f5a6ee8a2fb51fc44666bf To go along with it, here's a first pass at the documentation for writing extensions as tested on both this and a revised version of my palette extension. https://gist.github.com/workergnome/a161d3376a950ac7e283e6ec6630e1ec |
I wrote a comment on the gist but perhaps better to add here: The physdim extension looks good to me, I would be happy to import this into the prezi3 branch as /api/annex/exensions/physdim/index.md (to eventually become http://iiif.io/api/annex/exensions/physdim/) and roll any review/revision into the v3 process. We could then also use this extension as an example in the Image API v3 spec (in the full example, 5.8) |
Fine by me. |
Some minor comments on the referenced gist ...
And meta-wise:
|
I was assuming context should be just referenced but was included in the gist for convenience |
To the points above:
|
I think a near-the-top link to the context would be useful, but I don't think there's a lot of value in explicitly writing it out--the documentation is more useful. Don't have strong opinions abut the name--my only argument would be changing the name away from what it was called in prezi2 would add even more cognitive barriers for upgraders. |
For 4.0, proposal to bring this into the main spec, as any AR use will require it for 3d |
Following #1269, the Physical Dimensions service is no longer a service but an extension. We need to document it, as it is used in the wild. E.g.: https://data.ucd.ie/api/img/manifests/ucdlib:33064
The text was updated successfully, but these errors were encountered: