Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please split this package #11

Open
dkfellows opened this issue Sep 20, 2018 · 5 comments
Open

Please split this package #11

dkfellows opened this issue Sep 20, 2018 · 5 comments

Comments

@dkfellows
Copy link

Because this package supports plotting out of the box despite this not being the main purpose of the package, installing this package is really difficult to install in some environments (it's because matplotlib is tricky). Those environments include key use cases like some user configurations on MacOS X and on Continuous Integration services. Could you please split this package, perhaps into baseline csa and csa-plot (for the problem code, which is just in the csa/plot.py file), so that applications which don't need the plotting capability can install the rest of the code easily? Thanks!

@apdavison
Copy link
Member

Rather than splitting, which would increase the maintenance burden for @mdjurfeldt, would it work to just make the plotting optional? i.e. if you installed without matplotlib, then you would get an error message when trying to use the plot functions.

@mdjurfeldt
Copy link
Contributor

mdjurfeldt commented Sep 20, 2018 via email

@mdjurfeldt
Copy link
Contributor

@apdavison: We responded with the same idea simultaneously. 😊

@rowleya
Copy link

rowleya commented Sep 20, 2018

I think this would be fine for us (this was a request to make SpiNNaker software easier to install) - so long as matplotlib isn't listed as a requirement in setup.py or requirements.txt, it should work.

@Jay-sanjay
Copy link

hello , everyone I am a bit new to open-source contribution so would someone give me some issues to work on as a beginner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants