Removed more largo_featured_widget and restructured largo_about_widget #1469
Conversation
…ured_widget` as defaults.
…ents and a bit of restructure.
mikeschinkel
changed the title
| ? human_time_diff( $time, current_time( 'timestamp' ) ) | ||
| : date( 'F j, Y', $time ); | ||
|
|
||
| return sprintf( __( '<span class="time-ago">%s ago</span>', 'largo' ), $time ); |
There was a problem hiding this comment.
In the case of $time_difference being > 86400 seconds (1 day), this results in the output string being:
<span class="time-ago">August 23, 2017 ago</span>Can you remove this change from this PR, please?
| $message = sprintf( | ||
| __( '%sYou have not set a description for your site.%s Add a site description by visiting %sthe Largo Theme Options page%s.', 'largo' ), | ||
| '<strong>','</strong>', | ||
| "<a href=\"{$options_url}\" title=\"{$link_title}\">", '</a>' |
There was a problem hiding this comment.
Please use tabs for this indentation.
| /** | ||
| * @see https://github.com/INN/largo/issues/1467 | ||
| */ | ||
| // if ( ! dynamic_sidebar( 'footer-2' ) ) { |
There was a problem hiding this comment.
Commenting out this specific line prevents the footer-2 sidebar from displaying, since calling dynamic_sidebar( 'footer-2' ) is what causes that sidebar to be displayed. It may be best to comment out only the lines within the conditional, as you did in partials/footer-widget-3col-equal.php in this PR.
| /** | ||
| * @see https://github.com/INN/largo/issues/1467 | ||
| */ | ||
| // if ( ! dynamic_sidebar( 'footer-2' ) ) { |
There was a problem hiding this comment.
Commenting out this specific line prevents the footer-2 sidebar from displaying, since calling dynamic_sidebar( 'footer-2' ) is what causes that sidebar to be displayed. It may be best to comment out only the lines within the conditional, as you did in partials/footer-widget-3col-equal.php in this PR.
|
@benlk Sorry, the contributor day had lots of time pressure, so I didn't test like I should have. I will try to get to this over the weekend, if I can get my client obligations done before the end of the weekend. |
|
Hi Mike! |
|
@benlk Of course, go for it. |
Copies part of #1469 into the 0.5-dev branch. Co-authored-by: @mikeschinkel <mike@newclarity.net>
|
Finished in #1563; thanks for the work! |
Also restructured
largo_about_widgetto ensure no undeclared errors, added comments, created private initialization function for$instancefor DRY, addedesc_attr()is several places and made the code a little more readable.