Check if $instance['title'] is empty rather than $title for Largo Image Widget

[joshdarby]

Changes

This pull request makes the following changes:

• Fixes an issue where the widget title wasn't displaying in the Largo Image Widget, due to trying to use the $title variable which was removed when we stopped using extract in pull request #1565.

Why

For #1717.

Testing/Questions

Features that this PR affects:

• Largo Image Widget

Questions that need to be answered before merging:

• Are all other instances of title ok on other widgets?

Steps to test this PR:

1. Add Largo Image Widget to a sidebar.
2. Add a title to the Largo Image Widget.
3. Verify the title displays for the widget.

[pullrequest]

✅ A review job has been created and sent to the PullRequest network.

---

Check the status or cancel PullRequest code review here.

[pullrequest]

✖️ This code review was cancelled. See Details

[benlk]

Testing of this widget passes.

Regarding the question of the other widgets, I'll run through those quickly:

• largo-about.php
• largo-author-bio.php -> Largo Author Bio widget does not output a title for the widget #1737
• largo-disclaimer-widget.php -> Largo Disclaimer Widget doesn't display title or title link #1738
• largo-donate.php
• largo-facebook.php -> Largo Facebook Widget lacks a title field, but the form has a "Title URL" field in the settings page. #1739
• largo-follow.php
• largo-image-widget.php
• largo-post-series-links.php
• largo-prev-next-post-links.php
• largo-recent-comments.php
• largo-recent-posts.php
• largo-related-posts.php
• largo-series-posts.php
• largo-staff.php
• largo-tag-list.php
• largo-taxonomy-list.php
• largo-twitter.php -> Largo Twitter Widget lacks a title field, but the form has a "Title URL" field in the settings page. #1740

[joshdarby]

@benlk I can help with that. Just let me know which ones I can take.

[benlk]

You start from the bottom I'll start from the top? Check off items in my comment as we go, or edit it to reference issues.

[joshdarby]

editing this as I go:

largo-twitter.php doesn't have a title option, but rather a widget title link option, which doesn't work.

largo-series-posts.php title is taken from the name of the selected series.

largo-prev-next-post-links.php doesn't have a title option, but again has a widget title link option that doesn't work. Also throws this fun warning:

Notice: Undefined index: in_same_cat in /Users/josh/Desktop/Work/umbrella/wp-content/themes/largo-dev/inc/widgets/largo-prev-next-post-links.php on line 23

[benlk]

prev-next-posts I'd create an issue for, if only because we've got the title link field.

Let's merge this PR and then decide if all those other issues should be tackled in 0.6.4.