Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widget title link doesn't work on some widgets #1201

Closed
jackbrighton opened this issue Apr 21, 2016 · 2 comments
Closed

Widget title link doesn't work on some widgets #1201

jackbrighton opened this issue Apr 21, 2016 · 2 comments

Comments

@jackbrighton
Copy link

jackbrighton commented Apr 21, 2016

The Link field in widgets is supposed to make the widget Title a link to whatever url is entered in the Link field. With some but not all widgets, a url entered in the Link field has no effect.

Known widgets where the Link field doesn't work:

  • Largo Image Widget
  • Largo Author Bio widget (should probably not even have a Link field)
  • Largo Prev/Next Links widget (should not even have a Link field since there is no Title field)
  • Events Calendar widget (plugin)
  • Largo Series Posts
  • Largo Staff Roster
  • Saved Links
  • Link Roundups

Would need to do an audit of all widgets to complete this list.

In addition, having an option for a link title probably doesn't make sense in some cases:

  • Largo Explore Related
  • Largo Featured Posts ("In case you missed it")
  • Largo Disclaimer (this widget doesn't have a title field)
  • Largo Related Posts (defaults to Read Next. Even if used on a Series page, it's confusing to have a title link here)
  • Largo Tag List (Title defaults to "Filed Under" while each tag links to the tag archive page. No reason for the Title to have a link)
  • Largo Taxonomy List (contains links to taxonomy terms; the Title doesn't need a link)
@jackbrighton jackbrighton added this to the Backlog milestone Apr 21, 2016
benlk added a commit to INN/disclaimers that referenced this issue Jul 11, 2018
@benlk
Copy link
Collaborator

benlk commented Nov 9, 2018

The widget title link functionality described here would be a good candidate for pluginification.

@benlk benlk removed this from the Backlog milestone Apr 26, 2019
@benlk
Copy link
Collaborator

benlk commented Jul 9, 2019

Closing this in favor of individual issues, which are created as a review of widgets is completed in #1736.

@benlk benlk closed this as completed Jul 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants