-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor the saved links display metabox #80
Conversation
…ist_Table and how WP_Query interacts with wpdb
… coming back filled. But let's create some buttons.
…was because there were none in today
… for the filter button
Do we want tests for this? |
@benlk Yes, please, to tests. Also, in testing this, I discovered a bug when trying to publish a link roundup. After clicking the "publish" button, the page redirects to a "Are you sure you want to do this?" message. The link roundup post remains a draft when I navigate back to the post list page in the dashboard. |
I'm going to close this PR until this is mergeable, because the WIP tests are breaking actual functionality. The file isn't testable unless the WordPress admin isn't loaded, because the WordPress admin when loaded defines ABSPATH and the testing suite has already defined that. :/ |
Changes
inc/saved-links
and renamed its class toclone_WP_List_Table
. The reason for cloning this and not extending it is becauseWP_List_Table
is a private, unstable class that developerssay should not be directly extended.clone_WP_List_Table
to createSaved_Links_List_Table
with rendering options, columns, and a query specific for the lroundups-links posts.Saved_Links_List_Table
thead td
andthead td checkbox
so they appear the same as the inputs in the tbodyWhy
To hopefully make this more maintainable.
For #63.