Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The "module" functionality for pull quotes doesn't work. #12

Closed
benlk opened this issue Feb 27, 2019 · 3 comments
Closed

The "module" functionality for pull quotes doesn't work. #12

benlk opened this issue Feb 27, 2019 · 3 comments
Labels

Comments

@benlk
Copy link
Collaborator

benlk commented Feb 27, 2019

From https://thelensnola.test/2019/01/22/two-perspectives-on-new-orleans-at-301-a-celebration-of-resilience-a-call-for-rebellion/

Example post content:

[module align="left" width="half" type="pull-quote"]Did Landrieu break with the past? It depends on how you see the past, not to mention the present and future.[/module] The spectacle of the monuments coming down was also intended to symbolize death leading to municipal rebirth. What was meant to die with the monuments was the “Lost Cause” myth that defeated Confederates used to reestablish white might. As Landrieu spoke a crowd gathered down the street, at the circle formerly known as Lee, to watch a crane operator hoist the last of the four statues off its 60-foot column of Tennessee marble, set atop a 24-foot pedestal of Georgia granite.

Output on page under Largo 0.3ish:

<p><aside class="module pull-quote left half">Did Landrieu break with the past? It depends on how you see the past, not to mention the present and future.</aside>The spectacle of the monuments coming down was also intended to symbolize death leading to municipal rebirth. What was meant to die with the monuments was the “Lost Cause” myth that defeated Confederates used to reestablish white might. As Landrieu spoke a crowd gathered down the street, at the circle formerly known as Lee, to watch a crane operator hoist the last of the four statues off its 60-foot column of Tennessee marble, set atop a 24-foot pedestal of Georgia granite.</p>

Output on page under Largo 0.6.1:

<p><aside class="module pull-quote left half"></aside>The spectacle of the monuments coming down was also intended to symbolize death leading to municipal rebirth. What was meant to die with the monuments was the “Lost Cause” myth that defeated Confederates used to reestablish white might. As Landrieu spoke a crowd gathered down the street, at the circle formerly known as Lee, to watch a crane operator hoist the last of the four statues off its 60-foot column of Tennessee marble, set atop a 24-foot pedestal of Georgia granite.</p>

Note that the aside is empty.

So:

  • Is this a problem with the child theme?
  • Is this a problem with Largo?
@benlk benlk added the bug label Feb 27, 2019
@benlk
Copy link
Collaborator Author

benlk commented Feb 27, 2019

Switching to Largo and deactivating all plugins does not fix this problem. So this might be a bug in Largo.

@benlk
Copy link
Collaborator Author

benlk commented Mar 1, 2019

The temporary fix for this, approved, is to hide the pull quotes.

@benlk
Copy link
Collaborator Author

benlk commented Mar 1, 2019

Oh, also: They've been putting the module in the same line as the text of the paragraph, which means that browsers are parsing it as:

<p></p>
<aside class="module pull-quote left half"></aside>
The spectacle of the monuments coming down was also intended to symbolize death leading to municipal rebirth. What was meant to die with the monuments was the “Lost Cause” myth that defeated Confederates used to reestablish white might. As Landrieu spoke a crowd gathered down the street, at the circle formerly known as Lee, to watch a crane operator hoist the last of the four statues off its 60-foot column of Tennessee marble, set atop a 24-foot pedestal of Georgia granite.

The paragraph text is outside of the paragraph, because block elements don't nest like that.

benlk added a commit that referenced this issue Mar 15, 2019
benlk added a commit that referenced this issue Mar 15, 2019
@benlk benlk closed this as completed Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant