Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ft multidingo #30

Merged
merged 2 commits into from
Jun 28, 2024
Merged

Ft multidingo #30

merged 2 commits into from
Jun 28, 2024

Conversation

TomasMerva
Copy link
Contributor

I have changed the dingo and kinova launch files to incorporate namespaces. Also, there were some issues with few scripts (removing slashes, ...). Tested on both robots.

@TomasMerva TomasMerva requested a review from maxspahn June 24, 2024 12:30
maxspahn
maxspahn approved these changes Jun 28, 2024
View reviewed changes
Copy link
Contributor

@maxspahn maxspahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The config files are now demo specific but let's keep it like that. Ideally it would be in a separate workspace such that only the minimal configuration is in the dinova package.

@maxspahn maxspahn merged commit 120e546 into main Jun 28, 2024
@maxspahn maxspahn deleted the ft_multidingo branch June 28, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxspahn maxspahn maxspahn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TomasMerva @maxspahn