Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IQSS/10711 Cvoc updates #10712

Merged

Conversation

qqmyers
Copy link
Member

@qqmyers qqmyers commented Jul 21, 2024

What this PR does / why we need it: Together with #22, this PR is needed to deploy ORCID/ROR scripts in the author field.

Which issue(s) this PR closes:

Closes #10711

Special notes for your reviewer: @DS-INRA @luddaniel - I think this maintains compatibility with your changes, but it would be good to verify these don't break anything for you.

I also just included an a11y fix for the labels - basically a bug that I noticed in trying to check accessibility for the author/creator field.

Suggestions on how to test this: The simplest test is probably to deploy the updated ORCID/ROR scripts and this PR together and assure that they work together on the author field. (This PR is required for things to work and for the db to get the right values, but the scripts are mostly responsible for the exact look&feel.) Turning the scripts off (by deleting the :CVocConf setting) should show author name/idtype/id correctly set for ORCIDs and with ROR identifiers (vs org names) in the affiliation field. Leaving :CVocConf configured but disabling the scripts (e.g. by adding a typo in the scripts or changing the URLs for them in the CVocConf to be incorrect/give 404s) would let you see the DOM structure and confirm, for example, that the idType field is marked with a data-cvoc-managedfield attribute).

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?:

Additional documentation:

@qqmyers qqmyers added Size: 3 A percentage of a sprint. 2.1 hours. Consider For Next Release A simple change (eg bug fix) that would be good to prioritize since it has been seen in the wild GDCC: QDR of interest to QDR GDCC: DANS related to GDCC work for DANS Feature: Controlled Vocabulary Includes both Internal and external controlled vocabularies labels Jul 21, 2024
@DS-INRAE
Copy link
Member

Thanks for the mention, we will check if everything is compatible :)

@jeromeroucou
Copy link
Contributor

For information, I've run a few tests using the Ontoportal CVOC in addition to ROR and ORCID. I didn't notice any problems editing or displaying keywords. If needed, I can supply the configuration file used, which will need to be adapted to the metadata schemas (TSV file).

@coveralls
Copy link

coveralls commented Sep 6, 2024

Coverage Status

coverage: 20.872% (-0.001%) from 20.873%
when pulling f1218a3 on QualitativeDataRepository:QDR-CVoc_updates_for_author
into d40ce32 on IQSS:develop.

@cmbz cmbz added FY25 Sprint 6 FY25 Sprint 6 FY25 Sprint 7 FY25 Sprint 7 (2024-09-25 - 2024-10-09) labels Sep 23, 2024
@qqmyers qqmyers mentioned this pull request Sep 23, 2024
@scolapasta scolapasta added this to the 6.4 milestone Sep 23, 2024
@landreev landreev self-assigned this Sep 24, 2024
@landreev
Copy link
Contributor

Regardless of the comment in the external-vocab PR 22, I think I'm ready to merge this PR.
But could you please sync the branch with the main develop.
There's one funny exception stacktrace I am seeing in server.log; I think it should go away once the branch is updated, but I want to confirm.

@landreev
Copy link
Contributor

I believe it's all working. Merging.

@landreev landreev merged commit 050064e into IQSS:develop Sep 25, 2024
10 of 11 checks passed
@landreev landreev removed their assignment Sep 25, 2024
PaulBoon added a commit to DANS-KNAW/dataverse that referenced this pull request Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Consider For Next Release A simple change (eg bug fix) that would be good to prioritize since it has been seen in the wild Feature: Controlled Vocabulary Includes both Internal and external controlled vocabularies FY25 Sprint 6 FY25 Sprint 6 FY25 Sprint 7 FY25 Sprint 7 (2024-09-25 - 2024-10-09) GDCC: DANS related to GDCC work for DANS GDCC: QDR of interest to QDR Size: 3 A percentage of a sprint. 2.1 hours.
Projects
Status: Done 🧹
Development

Successfully merging this pull request may close these issues.

Feature Request/Idea: Allow ORCID and ROR to be used together in author field
8 participants