Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1109 travis ci build #1158

Merged
merged 21 commits into from
Oct 25, 2017
Merged

1109 travis ci build #1158

merged 21 commits into from
Oct 25, 2017

Conversation

miguelpdl
Copy link
Contributor

Finally got the IRATI stack to build on the Travis CI service. All is explained in the issue ticket](#1109).

This branch has the latest commits from the arcfire branch and gets a nice green tick mark beside it to show that the build passes.

The main point for review is that I had to remove the dependency on version 0.2.0 of librina in the configuration of rinad and rina-tools.

The system still checks that librina is there, but it does not check for a specific version.

The reason, this check is not done, is due to the fact that librina uses git-version-gen to create it's PACKAGE_VERSION, however in the Travis CI world the $VERSION that is generated by this system build is not passed as a global environment variable and thus the VERSION of librina gets set to UNKNOWN in it's package config file .pc. The knock on effect is that configure just bombs out when checking for librina at 0.2.0 or greater.

As stated with this change, the configure script still looks for librina but no version is specified.

Please review and let me know if any further changes are necessary.

Miguel Ponce de Leon added 21 commits October 18, 2017 15:38
…nd added to the configure as bootstrapping rinad.
@edugrasa edugrasa merged commit 0d64a3b into arcfire Oct 25, 2017
@vmaffione
Copy link
Contributor

@miguelpdl It's ok to remove dependency on that specific version of librina.
The current build system is needlessly complex and should be replaced with something way easier, with no separate packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants