-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1109 travis ci build #1158
Merged
Merged
1109 travis ci build #1158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uild environment.
…fig' so that the library path is updated.
…nd added to the configure as bootstrapping rinad.
…in configuration of rinad build.
@miguelpdl It's ok to remove dependency on that specific version of librina. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally got the IRATI stack to build on the Travis CI service. All is explained in the issue ticket](#1109).
This branch has the latest commits from the arcfire branch and gets a nice green tick mark beside it to show that the build passes.
The main point for review is that I had to remove the dependency on version 0.2.0 of librina in the configuration of rinad and rina-tools.
The system still checks that librina is there, but it does not check for a specific version.
The reason, this check is not done, is due to the fact that librina uses git-version-gen to create it's PACKAGE_VERSION, however in the Travis CI world the $VERSION that is generated by this system build is not passed as a global environment variable and thus the VERSION of librina gets set to UNKNOWN in it's package config file .pc. The knock on effect is that configure just bombs out when checking for librina at 0.2.0 or greater.
As stated with this change, the configure script still looks for
librina
but no version is specified.Please review and let me know if any further changes are necessary.