-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new service integration library #115
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here as in the other PR.#116
Dear @pcrespov , sorry for the lack of context. This is the main PR, which addresses the change of tooling regarding service integration (see issue ). The other one (make "make build" is secondary and work-in-progress). Regarding the elimination of bin/*, I did so imitating the structured of the more up-to-date cookiecutter of Jupyterlab services, which already uses |
Yes, I think here we need to align since there is some misunderstanding |
Hi Pedro, I agree. Let's discuss with @GitHK also. I am busy with other tasks at the moment and this isnt urgent, thus I propose we discuss about this in a few days. Best, Javier. |
- name: Checkout repo content | ||
uses: actions/checkout@v2 | ||
- name: ooil version | ||
uses: docker://itisfoundation/ci-service-integration-library:v1.0.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please make sure to use the latest version of this image. we are at 2.x.x currently.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please search and replace this repo wide
see issue
Moved to ci-service-integration-library. Rework of .osparc, Makefile, and file structure was needed.
Seems to work well; dummy project created with it is able to run "make build" without errors.