Prepass cleanup #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IceSentry
requested changes
Oct 13, 2022
| || key.contains(MeshPipelineKey::ALPHA_MASK) | ||
| { | ||
| let frag_shader_handle = if let Some(handle) = &self.material_fragment_shader { | ||
| handle.clone() | ||
| } else { | ||
| info!("no frag"); | ||
| DEPTH_PREPASS_SHADER_HANDLE.typed::<Shader>() | ||
| warn!("Missing Material::prepass_fragment_shader() for material with UUID {}. Rendering may be incorrect.", M::TYPE_UUID); |
There was a problem hiding this comment.
Oh, my old info log was just for debugging stuff. I'm not sure it's actually a mistake to not specify a custom prepass shader. Or at least, I'm not sure it deserves a warn, people just writing some simple materials shouldn't need to think about this I think. Maybe just log it as a trace instead?
There was a problem hiding this comment.
Yeah I'm not sure about this either. The shader/material stuff isn't clear to me, so I don't know if this is actually ever going to be a problem. We discussed issues with custom materials overwriting fragment/vertex shaders, and how that plays into writing normals, and how that interacts with alpha masks, but yeah. I'm not sure.
IceSentry
pushed a commit
that referenced
this pull request
Jun 26, 2024
…3905) # Objective - first part of bevyengine#13900 ## Solution - split `check_light_mesh_visibility `into `check_dir_light_mesh_visibility `and `check_point_light_mesh_visibility` for better review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEPTH_PREPASS_FORMATtoPREPASS_FORMATinprepass.rs. I'm not sure I understand what the depth stencil texture is used for.