Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: Tailscale #294

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

add: Tailscale #294

wants to merge 5 commits into from

Conversation

kd9lsv
Copy link
Contributor

@kd9lsv kd9lsv commented Oct 1, 2023

Would close #62

@raller1028
Copy link
Contributor

@kd9lsv We removed this application before because it uses host network and always conflict with CasaOS, then I saw that the network mode is still host in the pull request you submitted, so I would like to ask you the reason for this pull request?

@Stokkie64
Copy link

Stokkie64 commented Nov 29, 2023

@raller1028 I suspect @kd9lsv simply wants the app on the store.

Was the issue port conflicts with casaOS? Or was it clashing with NAT and DNS?

@kd9lsv
Copy link
Contributor Author

kd9lsv commented Nov 30, 2023

People already do it with it so I was trying to figure out why can people do it without issues.

See references.
https://icewhale.community/t/using-tailscale-to-remotely-access-casaos/278

https://icewhale.community/t/casaos-tailscale-seamless-home-network-integration-remote-access-to-your-data/84

@Stokkie64
Copy link

Yeah looks good to me, I'm going to add Twingate also soon to do the same as that's what I happen to use.
Which is why I'm curious what specific issues CasaOS had with using the Host network mode. So i can help try to resolve them.
Super useful tools these zero trust networks

@tigerinus
Copy link
Contributor

tigerinus commented Jan 17, 2024

Yeah looks good to me, I'm going to add Twingate also soon to do the same as that's what I happen to use. Which is why I'm curious what specific issues CasaOS had with using the Host network mode. So i can help try to resolve them. Super useful tools these zero trust networks

I find the 2 links great content about this app. I also believe this particular app Tailscale with network: host should just work fine with current PR.

The challenge is: As an AppStore, once we approve this app with network: host it would be some what challenging to justify future apps with network: host - even myself sometime just run a container with host mode so I don't have to figure out all the port mappings.

It's really on us to come up a more appropriate bar for app approvals before we can take any action on this PR - but we haven't really had anything concrete on top of our minds yet TBH.

If you have any ideas how this bar, a.k.a. AppStore Submission Guideline/Requirements/what-so-ever, should be drafted, particularly regarding Network Mode, please share.

--

BTW - this is why we've introduced 3rd party appstore to workaround such situation. :)

@tigerinus tigerinus requested review from tigerinus and removed request for CorrectRoadH January 17, 2024 08:11
@CorrectRoadH
Copy link
Member

@kd9lsv We removed this application before because it uses host network and always conflict with CasaOS, then I saw that the network mode is still host in the pull request you submitted, so I would like to ask you the reason for this pull request?

Is it work now?🤔 why host network mode not compatible with CasaOS?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[App Request] Tailscale
5 participants